New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shellcheck action to catch script errors #4533
base: dev
Are you sure you want to change the base?
Conversation
d486eaa
to
baa8dd7
Compare
Because this might force a lot of small changes - also in the sd card build area, lets target that change for v1.12.0 |
baa8dd7
to
40ecd60
Compare
@rootzoll d52f15c and 68b478d are catching errors which affect the run of the scripts already. Making these changes allows us to use shellcheck more rigorously so there are no new errors are introduced. If there are false positives espiacally around using |
Disabled checking the lines which are working correctly, but causing shellcheck errors. The rest are actual bugs. |
will need to fix or ignore errors
Can be run locally with act https://github.com/nektos/act :