Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/extensions #2404

Open
wants to merge 3 commits into
base: v1.7
Choose a base branch
from
Open

Conversation

m00ninite
Copy link

  • Add extensions menu
  • Add a recurring keysend helper extension
extension_demo-2021-07-05_19.00.39.mp4

A short explainer on what's going on this demo vid:

  1. User navigates to extensions menu (this menu is generated automatically based off scripts in /home/admin/extensions
  2. blitz.recurringpayment.sh is selected, script can be previewed and edited before committing to run it
  3. recurring payment script is run, new menus ask user for node pubkey, how many sats they want to send, and at what frequency
  4. script spits out a new keysend script and a crontab entry to paste into crontab.

@openoms
Copy link
Collaborator

openoms commented Jul 6, 2021

Thank you, loving this!

One possible improvement I can think of is to store the extensions on the disk so they are preserved during major updates with and SDcard (OS) change.
The usual place is /mnt/hdd/app-data where there could be an extensions directory owned by admin.

One problem with that is the disk is currently mounted with noexec in the fstab so nothing on it can be executable.
For now we need to store the extensions on the SDcard and redownload them after SDcard changes unless this changes #2405

@m00ninite
Copy link
Author

Could we automatically back up and restore the extensions folder when doing updates and manual backups? Unfortunately this wouldn't do anything for catastrophic failures of the SD, since the extensions would be stuck there.. but I envision extensions being fairly replaceable.

Alternatively, we could watch the extensions folder for changes and copy them over to the hdd when needed, a-la channel.backup

@rootzoll
Copy link
Collaborator

rootzoll commented Aug 3, 2021

I also like the idea of extensions ... but might delay it it bit to a v1.8.2, because we are changing quite a lot now on the menus and that will settle down after v1.8.0 release to make further modifications.

@rootzoll rootzoll added this to the 1.8.1 Release milestone Aug 3, 2021
@rootzoll rootzoll modified the milestones: 1.8.1 Release, 1.8.2 Release Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants