Chore: Remove default node #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-desktop-docs canceled.
|
|
Thank you for the heads up. Sounds like the Raspiblitzes should work as normal after this change. The rpcpassword is the same for the nodes on all networks. |
…esktop into chore/rid_of_defaultnode
This was referenced Jan 26, 2023
k9ert
commented
Jan 27, 2023
src/cryptoadvance/specter/node.py
Outdated
|
|
||
| @property | ||
| def bitcoin_core_version_raw(self): | ||
| raise Exception() |
There was a problem hiding this comment.
What? raise OR return!
moneymanolis
approved these changes
Jan 27, 2023
k9ert
added a commit
to k9ert/specter-desktop
that referenced
this pull request
Jan 30, 2023
* change passwordaspin auth implementation * env-var for RASPIBLITZ_SPECTER_RPC_LOGIN_BITCOIN_CONF_LOCATION * remove default * fix tests * fix the tests part2 * fix cypress tests * docstrings and other default removals * improve error_handling * do not raise exception
k9ert
added a commit
that referenced
this pull request
Jan 31, 2023
* Chore: Remove default node (#2072) * change passwordaspin auth implementation * env-var for RASPIBLITZ_SPECTER_RPC_LOGIN_BITCOIN_CONF_LOCATION * remove default * fix tests * fix the tests part2 * fix cypress tests * docstrings and other default removals * improve error_handling * do not raise exception * fixed debugging artifact * Spinning refresh icon if node is still syncing * Cypress test for sync status * remove notification of fully synced node * Set timeout for sync check to 5min --------- Co-authored-by: moneymanolis <moneymanolis@protonmail.com> Co-authored-by: Manolis Mandrapilias <70536101+moneymanolis@users.noreply.github.com>
4 tasks
|
@k9ert we are running into an error repeatedly in raspiblitz/raspiblitz#3709: The config is (+ tried some variations): Logs: The Can you help please about how should we change the config? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default node is quite annoying and makes things super complicated. This PR schould change that so that a default node is no longer needed.
rpcpasswordaspinwhich is used by raspiblitz to no longer use the default node. Instead it now simply assumes that there is an active node connection and if that is not the case, it searches the harddrive in the folder/mnt/hdd/bitcoinfor abitcoin.conffile and uses the connection details in that file to validate that the rpc-connection is valid with the password the user has provided. If that folder changes for some reason, it can be changed via modifying theRASPIBLITZ_SPECTER_RPC_LOGIN_BITCOIN_CONF_LOCATIONenv var. If the connection is not available (e.g. node down) the user can still login as the password is validated in that case with string comparison.src/cryptoadvance/specter/server_endpoints/auth.pywas heavily refactored.class NonExistingNode(PersistentObject). Whenever there is no node, then instead ofNone, an instance of this class is returned. It returns some minimum values which probably should get shrinked even further if we would continue to refactor the frontend-code.